Merge pull request #19 from n3wscott/lint

fix lint issues
cloudevents · Apr 2, 2021 · 0f65088 · 0f65088
2 parents ae61fa9 + 29c3edf
commit 0f65088
Show file tree

Hide file tree

Showing 9 changed files with 8 additions and 12 deletions.
diff --git a/.github/workflows/go-build.yaml b/.github/workflows/go-build.yaml
@@ -23,7 +23,6 @@ jobs:
         uses: actions/setup-go@v2
         with:
           go-version: ${{ matrix.go-version }}
-        id: go
 
       - name: Checkout code
         uses: actions/checkout@v2

diff --git a/.github/workflows/go-format.yaml b/.github/workflows/go-format.yaml
@@ -18,7 +18,6 @@ jobs:
         uses: actions/setup-go@v2
         with:
           go-version: 1.16.x
-        id: go
 
       - name: Checkout code
         uses: actions/checkout@v2

diff --git a/.github/workflows/go-lint.yaml b/.github/workflows/go-lint.yaml
@@ -18,7 +18,6 @@ jobs:
         uses: actions/setup-go@v2
         with:
           go-version: 1.16.x
-        id: go
 
       - name: Checkout code
         uses: actions/checkout@v2
@@ -28,9 +27,8 @@ jobs:
         with:
           files: .golangci.yaml
 
-      - name: Go Lint on ./v2
+      - name: Go Lint
         if: steps.golangci_configuration.outputs.files_exists == 'true'
         uses: golangci/golangci-lint-action@v2
         with:
           version: v1.29
-          working-directory: v2
diff --git a/.github/workflows/go-unit-test.yaml b/.github/workflows/go-unit-test.yaml
@@ -23,7 +23,6 @@ jobs:
         uses: actions/setup-go@v2
         with:
           go-version: ${{ matrix.go-version }}
-        id: go
 
       - name: Checkout code
         uses: actions/checkout@v2

diff --git a/go.mod b/go.mod
@@ -4,5 +4,5 @@ go 1.14
 
 require (
 	github.com/spf13/cobra v0.0.5
-	gopkg.in/yaml.v2 v2.2.2
+	gopkg.in/yaml.v2 v2.4.0
 )
diff --git a/go.sum b/go.sum
@@ -31,5 +31,6 @@ golang.org/x/sys v0.0.0-20181205085412-a5c9d58dba9a/go.mod h1:STP8DvDyc/dI5b8T5h
 golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
-gopkg.in/yaml.v2 v2.2.2 h1:ZCJp+EgiOT7lHqUV2J862kp8Qj64Jo6az82+3Td9dZw=
 gopkg.in/yaml.v2 v2.2.2/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
+gopkg.in/yaml.v2 v2.4.0 h1:D8xgwECY7CYvx+Y2n4sBz93Jn9JRvxdiyyo8CTfuKaY=
+gopkg.in/yaml.v2 v2.4.0/go.mod h1:RDklbk79AGWmwhnvt/jBztapEOGDOx6ZbXqjP6csGnQ=
diff --git a/pkg/commands/send.go b/pkg/commands/send.go
@@ -43,7 +43,7 @@ func addSend(topLevel *cobra.Command) {
 
 			// Process extensions.
 			if len(eo.Extensions) > 0 {
-				eo.Event.Attributes.Extensions = make(map[string]string, 0)
+				eo.Event.Attributes.Extensions = make(map[string]string)
 				for _, ext := range eo.Extensions {
 					kv := strings.SplitN(ext, "=", 2)
 					if len(kv) == 2 {

diff --git a/pkg/http/http.go b/pkg/http/http.go
@@ -83,7 +83,7 @@ func RequestToEvent(req *http.Request) (*event.Event, error) {
 
 	// CloudEvents attribute extensions.
 	event.Attributes.Extensions = make(map[string]string)
-	for k, _ := range req.Header {
+	for k := range req.Header {
 		if strings.HasPrefix(strings.ToLower(k), "ce-") {
 			event.Attributes.Extensions[k[len("ce-"):]] = req.Header.Get(k)
 			req.Header.Del(k)
@@ -92,7 +92,7 @@ func RequestToEvent(req *http.Request) (*event.Event, error) {
 
 	// Transport extensions.
 	event.TransportExtensions = make(map[string]string)
-	for k, _ := range req.Header {
+	for k := range req.Header {
 		event.TransportExtensions[k] = req.Header.Get(k)
 		req.Header.Del(k)
 	}

diff --git a/pkg/sender/sender.go b/pkg/sender/sender.go
@@ -43,7 +43,7 @@ func (s *Sender) Do() error {
 		if err != nil {
 			_, _ = fmt.Fprintf(os.Stderr, "Failed to dump request: %+v\n", err)
 		} else {
-			_, _ = fmt.Fprintf(os.Stderr, string(b))
+			_, _ = fmt.Fprint(os.Stderr, string(b))
 		}
 	}