Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements for CDP PvC DS Pre-Check #5

Open
Chaffelson opened this issue Jul 27, 2022 · 0 comments
Open

Improvements for CDP PvC DS Pre-Check #5

Chaffelson opened this issue Jul 27, 2022 · 0 comments
Assignees
@Chaffelson

Comments

@Chaffelson
Copy link
Contributor

Lifted from merge review by @jimright

  • A requirements.txt file with dependency Python packages would be good to include.
  • If it was possible to specify the input parameters in an input configuration file rather than editing the source directly, that would make the setup and reuse of the code easier.
  • For SSH to the remote nodes it would be nice to be able to optionally specify the username to be used with the SSH and SCP commands.
  • The option to disable SSH host key checking would be nice.
  • data_services-toolkit/DS_Pre-Install_Check/ReadMe.md should have instructions on where to set the configuration settings
  • The postgres_host setting is not actively used in the code and should be fixed up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chaffelson Chaffelson

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Chaffelson