Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 53 #18

Merged
merged 3 commits into from
Apr 13, 2023
Merged

Feature 53 #18

merged 3 commits into from
Apr 13, 2023

Conversation

nileshgadgi
Copy link
Member

what

  • Updated the Managed Disk name format for virtual machine.
  • Fixed the naming condition variable issue where condition was wrong, so fixed that.

why

  • Naming was directly assigned to the disk and format was not good so did that.
  • In the key vault's key resource, identity and object id was passing as a object and string was required. so changed it so that error may not occur during terraform plan and apply.

references

  • Link to any supporting jira issues or helpful documentation to add some context (e.g. stackoverflow).
  • Use closes #123, if this PR closes a Jira issue #123

@nileshgadgi nileshgadgi added the bug Something isn't working label Apr 13, 2023
@nileshgadgi nileshgadgi requested a review from d4kverma April 13, 2023 10:37
@nileshgadgi nileshgadgi self-assigned this Apr 13, 2023
@d4kverma d4kverma merged commit 1df5d14 into master Apr 13, 2023
@delete-merged-branch delete-merged-branch bot deleted the Feature-53 branch April 13, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants