Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: 🚀 Prepared addon for Keda #32

Merged
merged 9 commits into from
Oct 1, 2023
Merged

Feat: 🚀 Prepared addon for Keda #32

merged 9 commits into from
Oct 1, 2023

Conversation

ballalamit
Copy link
Contributor

No description provided.

@nileshgadgi
Copy link
Member

Update workflow to automate the keda readme file creation.

addons/keda/locals.tf Outdated Show resolved Hide resolved
@nileshgadgi
Copy link
Member

image
please remove this variable in kube-state-matrics

@ballalamit
Copy link
Contributor Author

image please remove this variable in kube-state-matrics

I have not worked on this addons, but I can remove this if gets the permission to remove from the owner of this addon
should I remove?

@nileshgadgi
Copy link
Member

image please remove this variable in kube-state-matrics

I have not worked on this addons, but I can remove this if gets the permission to remove from the owner of this addon should I remove?

I've worked on it. you can remove it.

@h1manshu98
Copy link
Member

KEDA outputs are missing in output.tf, please add them.

@ballalamit
Copy link
Contributor Author

KEDA outputs are missing in output.tf, please add them.

Done

override_values.tf Outdated Show resolved Hide resolved
override_values.tf Outdated Show resolved Hide resolved
Copy link
Member

@h1manshu98 h1manshu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anmolnagpal anmolnagpal merged commit 3c989cb into master Oct 1, 2023
11 checks passed
@anmolnagpal anmolnagpal deleted the feat/addon_keda branch October 1, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants