prometheus_alert_rules are not copied as expected

[arjuntoor1]

Hello, I am having problems with setting up default alerts in configuration.

Version: 2.3.3

---

Expected behaviour

When the prometheus_alert_rules file is populated with some rules, and I then provision the instance, a file should be created in {{ prometheus_config_dir }}/rules/basic.rules containing those rules.

Actual behaviour

The {{ prometheus_config_dir }}/rules/ directory exists but is empty, and Prometheus sees no alerts configured. This occurs even if I simply use the default value for prometheus_alert_rules

---

Other properties I am using (for example, prometheus_scrape_configs and prometheus_alertmanager_config) seem to work just fine.

[paulfantom]

Alerting rules are copied to {{ prometheus_config_dir }}/rules/ansible_managed.rules when there are two variables set:

• prometheus_alert_rules
• prometheus_alertmanager_config

We figured there is no need to create alerting rules when you don't have alertmanager configuration.

This task is responsible for that:

ansible-prometheus/tasks/configure.yml

Lines 2 to 15 in 80388e6

	- name: alerting rules file
	template:
	src: "alert.rules.j2"
	dest: "{{ prometheus_config_dir }}/rules/ansible_managed.rules"
	owner: root
	group: prometheus
	mode: 0640
	validate: "/usr/local/bin/promtool check rules %s"
	when:
	- prometheus_alertmanager_config != []
	- prometheus_alert_rules != []
	notify:
	- reload prometheus

[arjuntoor1]

Ah, I see. I had not provided prometheus_alertmanager_config since I was just trying to get the rules written to the file. This morning I moved on to AlertManager and now everything works as expected.

It would be good if it printed a message just like yours, i.e. "no need to create alerting rules when you don't have alertmanager configuration", in this case.

Also, a minor thing, the README states it will be copied to basic.rules but actually it's ansible_managed.rules.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.