-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to clean up the dentry cache can be used to clean up resources when VFS umount. #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyfjeff
requested review from
bergwolf,
imeoer,
jiangliu,
liubogithub and
eryugey
as code owners
September 18, 2023 08:47
zyfjeff
force-pushed
the
upstream-master
branch
from
September 18, 2023 08:50
9e0fb0d
to
07ba932
Compare
eryugey
approved these changes
Sep 18, 2023
zyfjeff
force-pushed
the
upstream-master
branch
from
September 20, 2023 13:21
07ba932
to
694a8ae
Compare
jiangliu
reviewed
Sep 20, 2023
jiangliu
reviewed
Sep 20, 2023
jiangliu
reviewed
Sep 20, 2023
jiangliu
reviewed
Sep 20, 2023
jiangliu
reviewed
Sep 20, 2023
jiangliu
reviewed
Sep 20, 2023
jiangliu
reviewed
Sep 20, 2023
In order to make the hot upgrade of virtiofs easy, VFS will save pseudo inodes when umount for easy recovery. However, in the fuse scenario, if umount does not remove the pseudo inode, it will cause an invalid directory to be seen on the host, which is not friendly to users. So add this option to control this behavior. Signed-off-by: zyfjeff <[email protected]>
umount returns the parent's inode information, so that it is convenient to call fuse's invali entry interface later to clarify the corresponding dentry cache Signed-off-by: zyfjeff <[email protected]>
zyfjeff
force-pushed
the
upstream-master
branch
from
September 21, 2023 02:22
741958c
to
18ebfee
Compare
Use the invalidate entry provided by the fuse kernel to clear the entry cache, all code references the libfuse implementation. ref: https://github.com/libfuse/libfuse/blob/f44214be6a2abb4c98f61790cae565c06bdb431c/lib/fuse_lowlevel.c#L2332 Signed-off-by: zyfjeff <[email protected]>
1. optimize the log of forget, for scenarios where forget cannot handle when the vfs submount is dropped by umount. 2. remove the error log printed when write fuse fails, and hand it to the caller to process and print. Signed-off-by: zyfjeff <[email protected]>
zyfjeff
force-pushed
the
upstream-master
branch
from
September 21, 2023 02:25
18ebfee
to
b3c4741
Compare
jiangliu
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make the hot upgrade of virtiofs easy, VFS will save pseudo
inodes when umount for easy recovery. However, in the fuse scenario, if
umount does not remove the pseudo inode, it will cause an invalid
directory to be seen on the host, which is not friendly to users. So add
this option to control this behavior.
umount returns the parent's inode information, so that it is convenient
to call fuse's invali entry interface later to clarify the corresponding
dentry cache
Use the invalidate entry provided by the fuse kernel to clear the entry
cache, all code references the libfuse implementation.
Optimize log output and print in vfs umount scenario
Signed-off-by: zyfjeff [email protected]
ref: https://github.com/libfuse/libfuse/blob/f44214be6a2abb4c98f61790cae565c06bdb431c/lib/fuse_lowlevel.c#L2332