Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As an operator, I want to remove cg-dashboard #1319

Closed
6 tasks done
spgreenberg opened this issue Mar 11, 2020 · 14 comments
Closed
6 tasks done

As an operator, I want to remove cg-dashboard #1319

spgreenberg opened this issue Mar 11, 2020 · 14 comments
Assignees
Labels
operations Platform operations, development, and support issues

Comments

@spgreenberg
Copy link
Contributor

spgreenberg commented Mar 11, 2020

A bug in stratos is currently requiring us to continue to run cg-dashboard: cloudfoundry/stratos#4103

Once this issue is fixed, deployed and validated in cg, we should remove cg-dashboard.

Acceptance Criteria

  • GIVEN The stratos bug is fixed
    AND stratos is updated in production with the bug fix
    WHEN a user accesses dashboard-deprecated.fr.cloud.gov
    AND looks in the docs for user management information
    THEN they are redirected to stratos
    AND the docs match stratos

Security considerations

be sure the stratos fix meets our needs. For example, a user should not be able to see and search for all users in a system. Instead, they should have to enter an exact username when setting a role.

Implementation sketch

  • Remove CircleCI access to the cg-dashboard repo (remove the webhook)
  • Archive the cg-dashboard repo
  • Update docs and remove references to dashboard-deprecated
  • Add a redirect for the legacy dashboard to the current Stratos dashboard
  • Validate Stratos dashboard docs on docs.cloud.gov show the correct procedure to manage users
@bengerman13
Copy link
Contributor

I think the AC here is overly-prescriptive of how to fix this.
It's possible Stratos will never fix the bug we reported, or that it will not be done in a timely manner, so we may need to instead work around it by plumbing the functionality into cg-uaa-extras or something like that

@hillaryj hillaryj added contractor-3-maintainability operations Platform operations, development, and support issues labels Mar 24, 2020
@karareinsel karareinsel changed the title As an operator, I want to remove cg-dashboard As an operator, I want to remove cg-dashboard (4/6) Mar 31, 2020
@karareinsel karareinsel changed the title As an operator, I want to remove cg-dashboard (4/6) As an operator, I want to remove cg-dashboard (4/20) Apr 6, 2020
@karareinsel
Copy link
Contributor

Will be blocked until the next stable release of Stratos. Ping Stratos to nudge them to cut a release.

@tammersaleh
Copy link
Contributor

For reference, we need this merged PR cloudfoundry/stratos#4172, which we hope will be in the next stable Stratos release.

@tammersaleh
Copy link
Contributor

@karareinsel
Copy link
Contributor

@tammersaleh can we ping the Stratos team again?

@tammersaleh
Copy link
Contributor

Here's the slack thread, and it looks like they just released the 3.1 RC, so hopefully the final release is just around the corner. If we don't see a final in a week, I think we should ping them.

@mheadd
Copy link
Contributor

mheadd commented Apr 27, 2020

Given that we've had a few customer inquiries relating to this issue, wondering if we need to do any follow up or outreach when the change is made.

@karareinsel
Copy link
Contributor

That's a good point @mheadd. We could put up a blog post or announce in office hours.

@ccostino ccostino self-assigned this Apr 28, 2020
@ccostino
Copy link
Contributor

I've started taking a look at this and testing the flow in the new 3.1.0 Stratos dashboard we have deployed and sure enough, the PR on the Stratos side is merged and working. It also accounts for the security consideration we have noted: you cannot see all users in the system, you must drill down to a specific org or space, and to add a user you must know their username and enter it in exactly to set a role(s) for that user in a given org/space.

You cannot add new users directly in the dashboard either, a user must exist in the system in order to add them to another org/space. To test this, I performed the following steps:

  • I registered a new user by signing up for a sandbox account
  • I logged into my admin account, and add that user as a Manager in an organization.
  • I then logged in as that new user to the new dashboard
  • As the new user, I found another existing sandbox user I had in the system and added them as a 'User' to an organization

An interesting thing happened with this, though: I could not see the newly created user in the organization, just the second user I had added.

I suspect this might be because I added the first new user to the organization before logging in with them, which means the account wasn't fully setup/verified; this could be an issue and something to specifically call out in guide, if not also fix if need be.

I took screenshots of what I had done and will test again with a fully set account to see if that user then shows up in the list in addition to the secondary added user.

Thank you @bengerman13 for the help and answering my questions!

@ccostino
Copy link
Contributor

ccostino commented Apr 29, 2020

It appears that the issue may have been that I didn't add my first new user as a User in addition Manager. Once I did that they showed up in the list.

This also explains why my own admin role wasn't showing up in the dashboard! I just confirmed this by assigning the User role to my admin account. This seems like it might be related to this bug: cloudfoundry/stratos#3974

@ccostino
Copy link
Contributor

Once the instructions are vetted and verified in cloud-gov/cg-site#1656, we ought to be able to send an updated notice about this to our customers that the new dashboard is ready to use and the old one will be retired.

@ccostino
Copy link
Contributor

I have created a draft StatusPage notice. Please edit and provide feedback!

@ccostino
Copy link
Contributor

ccostino commented May 4, 2020

StatusPage notice sent! Deprecation is set for 05/18/2020.

@karareinsel karareinsel changed the title As an operator, I want to remove cg-dashboard (4/20) As an operator, I want to remove cg-dashboard (5/18) May 6, 2020
@ccostino
Copy link
Contributor

This is now complete! Thank you @ChrisMcGowan and @bengerman13 for the help, I appreciate it!

@ccostino ccostino changed the title As an operator, I want to remove cg-dashboard (5/18) As an operator, I want to remove cg-dashboard May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
operations Platform operations, development, and support issues
Projects
None yet
Development

No branches or pull requests

7 participants