Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure there's a leading : when using cider-clojure-cli-aliases #3426

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Conversation

vemv
Copy link
Member

@vemv vemv commented Aug 22, 2023

In words of Alex Miller:

aliases should always use :
in some cases, aliases without colons are tolerated (but don't do that)

This PR is a preventive measure, fixing no issue in particular.

@vemv vemv requested a review from bbatsov August 22, 2023 15:37
cider.el Outdated
@@ -804,7 +804,10 @@ your aliases contain any mains, the cider/nrepl one will be the one used."
(if cider-clojure-cli-aliases
;; remove exec-opts flags -A -M -T or -X from cider-clojure-cli-aliases
;; concatenated with :cider/nrepl to ensure :cider/nrepl comes last
(format "%s" (replace-regexp-in-string "^-\\(A\\|M\\|T\\|X\\)" "" cider-clojure-cli-aliases))
(let ((stripped (format "%s" (replace-regexp-in-string "^-\\(A\\|M\\|T\\|X\\)" "" cider-clojure-cli-aliases))))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just name this alias.

@bbatsov bbatsov merged commit 73f0d05 into master Aug 24, 2023
@bbatsov bbatsov deleted the 3123 branch August 24, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants