Let sync op failures use stacktrace viewer

[sanjayl]

Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

• The commits are consistent with our contribution guidelines
• You've added tests (if possible) to cover your change(s)
• All tests are passing (make test)
• The new code is not generating bytecode or M-x checkdoc warnings
• You've updated the changelog (if adding/changing user-visible functionality)
• You've updated the readme (if adding/changing user-visible functionality)
• You've updated the refcard (if you made changes to the commands listed there)

Thanks!

This lets sync ops use the stacktrace viewer, just like how async ops
currently do. Requires some changes to the CIDER-nREPL code as well
which were submitted as CIDER-nREPL PR 327
clojure-emacs/cider-nrepl#327.

[bbatsov]

Btw, why is this called pp-stacktrace?

[bbatsov]

One more thing - mention this in the changelog as well.

[bbatsov]

There's a byte-compilation issue with the PR, but I'll fix it myself. Thanks!

[sanjayl]

Oh shoot, sorry about that! Will double check next time

On Fri, Apr 1, 2016 at 3:08 PM, Bozhidar Batsov [email protected]
wrote:

There's a byte-compilation issue with the PR, but I'll fix it myself.
Thanks!

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#1645 (comment)