Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restarting CLJS repl when using cider-restart #1874

Open
leppert opened this issue Oct 28, 2016 · 4 comments
Open

Restarting CLJS repl when using cider-restart #1874

leppert opened this issue Oct 28, 2016 · 4 comments
Labels
enhancement good first issue A simple tasks suitable for first-time contributors

Comments

@leppert
Copy link

leppert commented Oct 28, 2016

cider-jack-in-clojurescript is a great convenience method for booting up a piggiebacked ClojureScript REPL. It'd be handy to have an equally easy way to restart both the primary CLJ and piggiebacked CLJS repls, perhaps by modifying or extending cider-restart.

Does this already exist by chance? Any big barriers to its existence?

@bbatsov
Copy link
Member

bbatsov commented Oct 30, 2016

I think it will be really easy to extend to cider-restart restart both REPLs. The only reason we haven't done is probably because we didn't think about this. I don't do ClojureScript development myself and rarely come up with ideas to improve the ClojureScript support in CIDER.

@dpsutton
Copy link
Contributor

dpsutton commented Jan 6, 2017

As far as I can tell, this feature is implemented?

(defun cider-restart (&optional restart-all)
  "Restart the currently active CIDER connection.
If RESTART-ALL is t, then restarts all connections."
  (interactive "P")
  (cider-ensure-connected)
  (if restart-all
      (dolist (conn cider-connections)
        (cider--restart-connection conn))
    (cider--restart-connection (cider-current-connection))))

Have you tried this with a prefix?

@dpsutton
Copy link
Contributor

dpsutton commented Jan 6, 2017

Looks like the clojurescript repl comes back but doesn't "know" to run its invoking stuff: ie, the initial invoking of the cljs repl. also looks like a couple errors pop up at the bottom as well.

@bbatsov
Copy link
Member

bbatsov commented Jan 7, 2017

Seems we need a solution similar to the one tracking the invocation command here #1905 //cc @cskksc

@bbatsov bbatsov added good first issue A simple tasks suitable for first-time contributors and removed good first issue A simple tasks suitable for first-time contributors low hanging fruit labels May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue A simple tasks suitable for first-time contributors
Projects
None yet
Development

No branches or pull requests

3 participants