fix: correct handling of ALLOCATE AVAILABLE calls where arguments are subscripted variables
#590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amples to function docs
…s and gen-equation-{c,js}
Also update a few gen-equation tests to account for removal of normalizeSubscripts
… in some existing tests
…LAY3 function impl
…ltiple dimensions resolve to the same family
…xpandedRefIdsForVar
…ions resolve to the same family when generating equation code
Fix is from Todd's fork. Will add tests later.
… involving multiple dimensions
…eadEquation phase
…OCATE AVAILABLE code gen
…ndled differently
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #377
See issue for more details. The existing
ALLOCATE AVAILABLEtests are passing, as are the new ones added on this branch, so this is ready to be merged.