Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unit tests to check unsorted preprocessor output #583

Closed
chrispcampbell opened this issue Dec 8, 2024 · 0 comments · Fixed by #584
Closed

Update unit tests to check unsorted preprocessor output #583

chrispcampbell opened this issue Dec 8, 2024 · 0 comments · Fixed by #584
Assignees

Comments

@chrispcampbell
Copy link
Contributor

chrispcampbell commented Dec 8, 2024

When I first added the new unit tests (in read-{subscripts,variables,equations}.spec.ts), the tests that check the output of those phases for the sample tests have the variables in the order produced by the legacy preprocessor at that time, which sorted variables roughly by LHS variable name.

Now that the #575 has been merged (which removed the legacy preprocessor), it's no longer necessary to have those tests compare to the sorted items. It would be more consistent to compare to the definitions in the original order from the source model.

This change only affects the tests, no change in behavior of the compiler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant