fix: update default plugin-check configuration to include comparison yaml files #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… + change location of sample checks.yaml file
chrispcampbell
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #571
This fixes the plugin-check package to read comparison definitions from
**/comparisons/*.yamland changes the glob patterns so that we read the check definitions from the new preferred location**/checks/*.yaml.This also updates the create package to generate a sample
comparisons.yamlfile and updates the location of the samplechecks.yamlfile to match the new preferred location.I also updated the hello-world and sir examples to use the new recommended directory structure and yaml file naming.