Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect summary in model-check tabs #554

Closed
chrispcampbell opened this issue Oct 16, 2024 · 2 comments · Fixed by #555 or #556
Closed

Incorrect summary in model-check tabs #554

chrispcampbell opened this issue Oct 16, 2024 · 2 comments · Fixed by #555 or #556
Assignees
Labels

Comments

@chrispcampbell
Copy link
Contributor

In a recent change (see PR #551) I refactored the code that adds up the number of scenarios or datasets that have differences. It looks like I introduced a bug because the tabs in the model-check summary page are now showing the total number of rows rather than the number of rows with significant differences:

Image


The problematic code is here:

Image

Image

@chrispcampbell chrispcampbell self-assigned this Oct 16, 2024
@chrispcampbell
Copy link
Contributor Author

The code was changed accidentally to calculate the total number of rows. It needs to be changed back similar to how it was before, where we subtract the "without diffs" count from the total number of rows.

@chrispcampbell
Copy link
Contributor Author

The tabs now show the correct summaries in the case where there are no differences:

Image

And the correct summaries when there are some differences:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant