Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for displaying more than 3 graph boxes in one row in detail view #545

Closed
chrispcampbell opened this issue Oct 7, 2024 · 1 comment · Fixed by #546 or #542
Closed

Allow for displaying more than 3 graph boxes in one row in detail view #545

chrispcampbell opened this issue Oct 7, 2024 · 1 comment · Fixed by #546 or #542

Comments

@chrispcampbell
Copy link
Contributor

chrispcampbell commented Oct 7, 2024

Currently there is a hard coded limit (3) on the number of graph boxes that can appear in a row in the detail view in a model-check report. The reason for the limit was because the model-check interface was originally designed around the most basic use case of showing 3 different scenarios for each dataset (at default, at min, at max). Now we have use cases that would benefit from being able to show more than 3 (like 7 or 8) boxes in a single row.

As part of fixing this, I will be removing the font-size: 1vw trick to make the UI scale proportional to the browser window width. This was an OK solution a long time ago, but it prevents browser zoom from working properly. Additionally the layout for the detail view is currently set up to prevent horizontal scroll (an artifact of the previous limit of 3 items per row). Now that we will allow for any number of boxes per row, we should fix up the CSS so that horizontal scroll works correctly.

@chrispcampbell
Copy link
Contributor Author

To better support the case where a row has many items (causing the horizontal scrollbar to appear), I added a new "Graph Zoom" slider that allows for scaling the comparison graphs without affecting the size of the text. This makes it easier to fit more graphs in the window at once without scrolling (too much).

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment