fix: update to latest antlr4-vensim with support for Unicode characters in variable names #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e characters in model variable names
…de characters in variable names
|
Todd agrees this is low risk. I've published [email protected] that includes the fix. I will merge this PR now and will publish new versions of the parse/compile/cli packages shortly. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #532
@ToddFincannonEI: This is the companion to the antlr4-vensim PR climateinteractive/antlr4-vensim#14 that I just filed.
This one updates SDE to use the gitpkg (pre-release) version of antlr4-vensim containing the fix and adds an integration test to verify that it no longer chokes on non-Latin characters in variable names.
Once you approve these PRs, I'll publish antlr4-vensim and will update this one before merge to use the latest published version instead of the gitpkg version.