Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add optional outListingFile config property that copies model listing JSON file as post-generate step #493

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

chrispcampbell
Copy link
Contributor

Fixes #492

This adds a new optional outListingFile property to UserConfig (as used in sde.config.js), which simplifies the process of copying the model listing file to a specific location, like a source code directory.

The one place where this was relevant was the new house-game example. I was able to simplify the sde.config.js file for that project to use this new property instead of the old workaround, which was a custom plugin that copied the file.

As part of this, I updated the build package tests to remove the sde-prep directory between runs, and moved the build-dev and build-prod tests into separate directories, since before there was a chance that they would share the same sde-prep directory, which could lead to race conditions.

@chrispcampbell chrispcampbell merged commit af4abbe into main Jun 4, 2024
6 checks passed
@chrispcampbell chrispcampbell deleted the chris/492-copy-listing-json branch June 4, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optionally copy model listing JSON file as post-generate step
1 participant