-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update build and plugin packages to support JS code generation #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eC methods with pre/postGenerateCode
[skip ci]
…from C code gen to JS code gen
…s for JS code gen
…ead of brackets to match behavior of canonicalVensimName in compile package
For the time being, the JS code gen only allows INITIAL TIME, FINAL TIME, and TIME STEP to be defined as constants, and probably the C code should do the same since it's unlikely to have a model that defines FINAL TIME as an aux like in the previous version of this test model.
…csv file" This reverts commit d67c1fb.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #479
See issue for more details.
sde
commands has shifted to JS code generation instead of C/Wasm code generation. Existing projects that want to continue using Wasm generation viaplugin-wasm
only need to make one small change in thesde-config.js
file, as noted in #479./cc @ToddFincannonEI