Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update build and plugin packages to support JS code generation #487

Merged
merged 28 commits into from
May 24, 2024

Conversation

chrispcampbell
Copy link
Contributor

Fixes #479

See issue for more details.

⚠️ With this set of changes (along with the other changes in the prior PR #486), the default behavior for the sde commands has shifted to JS code generation instead of C/Wasm code generation. Existing projects that want to continue using Wasm generation via plugin-wasm only need to make one small change in the sde-config.js file, as noted in #479.

/cc @ToddFincannonEI

…ead of brackets to match behavior of canonicalVensimName in compile package
For the time being, the JS code gen only allows INITIAL TIME, FINAL TIME, and TIME STEP to be defined as constants, and probably the C code should do the same since it's unlikely to have a model that defines FINAL TIME as an aux like in the previous version of this test model.
@chrispcampbell chrispcampbell merged commit 18b0873 into main May 24, 2024
6 checks passed
@chrispcampbell chrispcampbell deleted the chris/479-build-js branch May 24, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update build and plugin packages to support JS code generation
1 participant