fix: remove old implementation of read and code gen phases #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e dependencies for the parse package only)
This code was used long ago for synthesizing lookups for external data that is not referenced in the model, but Todd and I decided that the code is no longer relevant and should be removed.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #448
@ToddFincannonEI: This removes the old implementation files as described in the issue, and removes all code that was previously under control of the temporary
SDE_NONPUBLIC_USE_NEW_PARSEenvironment variable or "vensim-legacy"kindvalue.I also updated the
package.jsonfor the compile package so that it no longer has a direct dependency on the antlr and antlr4-vensim packages (now only the parse package depends on those).Also check out this issue comment about the revamp of the Transpiler Architecture wiki page, which I undertook as part of this issue.