Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent error in JSON listing creation when Time variable is not explicitly referenced in the model #368

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

chrispcampbell
Copy link
Contributor

Fixes #365

This includes a new variant of the JS-level integration test from my earlier PR, so now we cover both scenarios (with and without Time explicitly referenced).

@chrispcampbell chrispcampbell merged commit 4bf0a39 into main Sep 29, 2023
3 checks passed
@chrispcampbell chrispcampbell deleted the chris/365-unreferenced-time branch September 29, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error thrown in isInternal when Time variable is not explicitly referenced in the model
1 participant