Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce cost of control parameter initialization #305

Open
chrispcampbell opened this issue Dec 13, 2022 · 0 comments
Open

Reduce cost of control parameter initialization #305

chrispcampbell opened this issue Dec 13, 2022 · 0 comments

Comments

@chrispcampbell
Copy link
Contributor

In the fix for #301, in order to initialize the control parameters (in the accessors used by the runtime packages), we are now calling initConstants, initLevels, and evalAux, which means we are executing many unnecessary statements.

We should consider changing the code gen to initialize the control parameters separately. We should also consider compile-time validation of the control parameters to see if they can be resolved to a constant value.

There is some overlap here with the API considerations being made in #302, so it would be good to ponder these two issues together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant