Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle subdimensions correctly for GET DIRECT CONSTANTS #125

Merged
merged 7 commits into from
Oct 14, 2021

Conversation

ToddFincannon
Copy link
Collaborator

@ToddFincannon ToddFincannon commented Oct 6, 2021

Fixes #124
Fixes #134

Details in issue #124.

(Edit by Chris: This also resolves the regression reported in #134, so I've included my except test modifications on this branch so that we have additional test coverage for that particular case, which did not use GET DIRECT CONSTANTS.)

@ToddFincannon ToddFincannon added this to the 0.6.0 milestone Oct 6, 2021
@chrispcampbell chrispcampbell changed the title Todd/124 const subdimension fix: handle subdimensions correctly for GET DIRECT CONSTANTS Oct 8, 2021
Copy link
Contributor

@chrispcampbell chrispcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ToddFincannon I verified that both En-ROADS and C-ROADS are able to be built with this branch (it resolves the En-ROADS regression that I reported in #134). I included the tests I wrote for that issue in this branch for additional coverage.

I'm trusting that the changes here resolve the issues at hand since the tests all pass, but I wish I had a better understanding of the subscript/dimension handling code in SDE (and how they're handled by Vensim in general). I'm keen to (someday) tease some of the subscript handling code out into separate modules that can be more precisely unit tested, which I think would help make it easier for me to understand how these pieces fit together, but that's for another day. In the meantime, I'll get this merged and will continue with the other PRs.

@chrispcampbell chrispcampbell merged commit 2fdfb34 into develop Oct 14, 2021
@chrispcampbell chrispcampbell deleted the todd/124-const-subdimension branch October 14, 2021 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants