fix: terminate generated equations with ~~| #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrispcampbell
changed the title
chrispcampbell
changed the title
…r4-vensim@7911c04
…to split on '|' delimiter)
chrispcampbell
approved these changes
Sep 27, 2021
There was a problem hiding this comment.
@ToddFincannon Looks good! I tested with the En-ROADS build and didn't encounter any problems.
JFYI, after I merged climateinteractive/antlr4-vensim#8, I updated the package.json on this branch to use the latest develop commit from the antlr4-vensim repo. Note that I backed out all unrelated changes in package-lock.json (except for the antlr4-vensim part) from your earlier commit 0928349; they were probably a side effect of when you updated the antlr4-vensim reference. When we're ready to upgrade other packages, we can do that under a separate issue/branch to keep the git history clean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119
This change is required when using antlr4-vensim#7911c04 (see related issue climateinteractive/antlr4-vensim#7). I branched from develop so it can be merged immediately test test the antlr4-vensim change.