Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated tests #90

Merged
merged 6 commits into from
Feb 28, 2023
Merged

Updated tests #90

merged 6 commits into from
Feb 28, 2023

Conversation

GhostOps77
Copy link
Contributor

Updated and Improved tests a little bit

This PR has some little bit tidy-ed up code for tests

@GhostOps77
Copy link
Contributor Author

As the previous PRs have solved this issue

It's better to close this issue as well, and I've added a help param to an option in the tests/test_basic.py file to test it

And you can also close this issue as well, as the CommandCollection does get supported to the current version of click-repl

Sorry for the inconvenience, I've forgot to add the help argument to the option decorator, but this commit includes it
Added hyperlink to the gh-action tests page
@auvipy auvipy self-requested a review February 28, 2023 15:25
@GhostOps77
Copy link
Contributor Author

GhostOps77 commented Feb 28, 2023

@auvipy Does this module support all the way up to python v2.7?
cuz if not, you can close this issue as well

I didn't make any test cases for python 2.7, and I don't think I would add those test cases and py2.7 support for this module, as py2 is dead 3 years ago

And also, don't forget to look on the issues that I've mentioned above

@auvipy auvipy merged commit 4bb985e into click-contrib:master Feb 28, 2023
@GhostOps77 GhostOps77 deleted the updated-tests branch February 28, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants