Merged PR#97 with tests #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deleted: tests/test_basic.py deleted: tests/test_completion/test_common_tests/test_arg_completion.py deleted: tests/test_completion/test_common_tests/test_option_completion.py
Replaced version based _resolve_context with custom function: click_repl/_completer.py Added InvalidGroupFormat Exception Class: click_repl/exceptions.py Added custom _resolve_context function: click_repl/utils.py
Added mock_stdin: tests/__init__.py Added tests for group with options and args: tests/test_repl.py
Added ctx to completer: tests/test_command_collection.py Added ctx to completer: tests/test_completion/test_click_version_ge_8/test_arg_completion_v8.py Added ctx to completer: tests/test_completion/test_click_version_ge_8/test_option_completion_v8.py Added ctx to completer: tests/test_completion/test_click_version_le_7/test_arg_completion_v7.py Added ctx to completer: tests/test_completion/test_click_version_le_7/test_option_completion_v7.py Added ctx to completer: tests/test_completion/test_common_tests/test_hidden_cmd_and_args.py Renamed: tests/test_completion/test_path_type/test_path_type.py -> tests/test_completion/test_path_type.py
|
If u r merging this PR, you can close this PR |
|
I want to merge that PR first, can you rebase after that? |
auvipy
requested changes
May 21, 2023
| basepython = python3.7 | ||
| deps = flake8 | ||
| commands = flake8 click_repl tests | ||
| [testenv:click6] |
There was a problem hiding this comment.
It seems like this module should support click v6, as there's an implementation of ClickExit Exception in the exceptions file
So, I've added click v6 tests as well
@auvipy Sure, You can merge that PR first |
|
you don't have to close you can re base I think |
|
@auvipy ok, you can proceed |
|
can you please come with the relevant part to fix #92 first |
|
@auvipy I'll just close this branch, and come up with a new one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged #97 with some tests, and some other quality edits
Resolves #92