Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for ppc64le. #8611

Open
Sunidhi-Gaonkar1 opened this issue Jan 23, 2024 · 8 comments
Open

Adding support for ppc64le. #8611

Sunidhi-Gaonkar1 opened this issue Jan 23, 2024 · 8 comments
Labels
blocked enhancement a request to improve CLI

Comments

@Sunidhi-Gaonkar1
Copy link

Describe the feature or problem you’d like to solve

Hi team, in reference to #3615, requesting to add ppc64le support.

Proposed solution

I was able to build gh-cli from source following the instructions mentioned in https://github.com/cli/cli/blob/trunk/docs/source.md. I was also able to test the binary succesfully. Attaching below the build and test logs for the same.
gh-cli-logs.txt

I will raise a PR shortly. Thank you.

Additional context

We are working on supporting OpenSearch distribution for ppc64le architecture, which has a dependency on gh-cli. opensearch-project/opensearch-build#3122 (comment)

@Sunidhi-Gaonkar1 Sunidhi-Gaonkar1 added the enhancement a request to improve CLI label Jan 23, 2024
@cliAutomation cliAutomation added the needs-triage needs to be reviewed label Jan 23, 2024
@williammartin williammartin added the discuss Feature changes that require discussion primarily among the GitHub CLI team label Jan 23, 2024
@williammartin
Copy link
Member

Hi @Sunidhi-Gaonkar1, thanks for opening this issue.

As in #3615, I'm not sure that we can commit to supporting this because we don't have an environment to continuously test it on. While you might have successfully tested it locally (thanks!) we will be in the dark going forward with every change. We also lack a development environment should any issues actually occur. Additionally, with limited resources, if we did break it, I'm not sure that we would prioritise fixing it given the interest we've seen in having it supported so far.

I've labelled this discuss to chat with the team about what we want to do here. It's a valid and understandable request and I want to keep it open so that the community can express their desire for this support. It appears that in the meantime you can build from source.

Also going to tag @mgiessing on here since he opened the original request some years ago, and may have had thoughts since then.

@seth-priya
Copy link

Hi @williammartin thanks for your response !

Just wanted to mention a few things

  • Access to a Power VM can be requested from https://osuosl.org/services/powerdev/request_hosting/ for builds / testing
  • We can work on enabling the CI like was done here adding support for ppc64le arch open-telemetry/opentelemetry-collector#5645 for builds / packaging (just as an example of one of the communities of the work done by our team)
  • Currently, we don't have native Power support in GitHub actions so we might not be able to provide an easy alternative for running unit tests and such but we are working towards a solution that can enable us to add that support in future. However, having said that, since, this is mostly all go code, based on my experience with building/validating go packages on Power, I really don't think that we will end up breaking anything specifically for Power (unless some go assembly code / optimizations are added)

@mgiessing your thoughts as well? Thanks!

@williammartin williammartin added blocked and removed discuss Feature changes that require discussion primarily among the GitHub CLI team needs-triage needs to be reviewed labels Feb 21, 2024
@jauder-ho-nttd
Copy link

+1 for releasing a ppc64le binary

Maybe it can be tagged/labeled as unsupported but it would be helpful rather than having to build from source.

@williammartin
Copy link
Member

Thanks for the extra support to help us prioritise. What's your use case @jauder-ho-nttd ?

@jauder-ho-nttd
Copy link

jauder-ho-nttd commented Mar 12, 2024

@williammartin Running ansible on a P10 LPAR as the controller and using GitHub for source control.

@runlevel5
Copy link

Any update on this? I have been building from source for a quite without facing any issue.

@williammartin
Copy link
Member

Hey @runlevel5, thanks for chiming in. No real update since we closed #8612.

Always happy to revisit decisions as we get more information though. What's your use case?

@runlevel5
Copy link

@williammartin my usecase is basically just daily interaction with GitHub for work (which happens to be on a IBM POWER9-based workstation). AFAIK there are lots of education and big firms that use POWER-based hardware do utilise GitHub for application development collaboration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked enhancement a request to improve CLI
Projects
None yet
Development

No branches or pull requests

6 participants