Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the 'sub' OAuth User Info property #2057

Conversation

chanioxaris
Copy link
Member

🔎 Previews:

What does this solve?

What changed?

Checklist

  • I have clicked on "Files changed" and performed a thorough self-review
  • I have added the "deploy-preview" label and added the preview link(s) to this PR description
  • All existing checks pass

@chanioxaris chanioxaris requested a review from a team as a code owner February 25, 2025 08:00
@@ -67,6 +67,7 @@ The `/oauth/userinfo` endpoint provides the following user properties, depending
| Property | Description |
| - | - |
| `user_id` | The ID of the user |
| `sub` | The ID of the user |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just confirming, both the user_id and the sub is the ID of the user?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct! The sub is required based on the OpenID Connect spec and the user_id was exposed before, so we can't really remove it

@alexisintech alexisintech merged commit 2945ce1 into main Feb 26, 2025
5 checks passed
@alexisintech alexisintech deleted the haris/user-1317-add-missing-sub-field-to-oauthuserinfo-endpoint-response branch February 26, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants