Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iterables #7

Merged
merged 50 commits into from
Apr 5, 2023
Merged

Iterables #7

merged 50 commits into from
Apr 5, 2023

Conversation

luis-camero
Copy link
Collaborator

Decorations:

  • maintains changes from previous PR (i.e. list of bumpers and top plates)
  • no longer contains PACS risers or brackets

Mounts:

  • iterable over each model type, similar to sensors
  • mount names are no longer a required val, automatically set to prefix_0
  • name of mounts is based on their position in the OrderedListConfig

@luis-camero
Removed unecessary platform specific decorations
78e9ab3
@luis-camero
Added base decorations config
f4e0dee
@luis-camero
Removed PACS specific configs
c0d1346
@luis-camero
Added get and set functions to ListConfig
d9d1fad
@luis-camero
Fixed assertion indenting
99698ec
@luis-camero
Removed unused imports
e530093
@luis-camero
Fixed assertion indenting
5d5b36c
@luis-camero
Updated A200 to iterable decorations
5902e23
@luis-camero
Updated J100 to iterable decorations
e54062c
@luis-camero
Updated path to config in Platform
9e1f353
@luis-camero
Updated path to base decorations config
240487b
@luis-camero
Switched parser to new decorations config
f2b5984
@luis-camero
Removed PACS Config testers
6ccddb5
@luis-camero
Fixed lint errors in clearpath_config
3f88d69
@luis-camero
Fixed lint errors in mounts
3012a17
@luis-camero
Moved ListConfig
5c6aaa3
@luis-camero
Updated remove function
5422062
@luis-camero
Removed mount pseudo namespace
05ad4ec
@luis-camero
Small lint fixes in common
75772fa
@luis-camero
Added get and set methods for individual mounts
1dda483
@luis-camero
Split up mounts
fdd47da
@luis-camero
Added uid checks to ListConfig
21b9305
@luis-camero
Removed mounting link and model
feb651e
@luis-camero
Removed mounting link from fath and flir moutns
d04cab7
@luis-camero
Added OrderedListConfig
d6d69ef
@luis-camero
Added name from id to BaseMount
830b7e9
@luis-camero
Removed name as a default parameter
fd346fe
@luis-camero
Removed PACS from platform
9098936
@luis-camero
Moved ListConfig and all PACS from the Platform base
7e07db6
@luis-camero
Added mounts as individual ordered lists
580e2f1
luis-camero added 19 commits April 4, 2023 10:45
@roni-kreinin roni-kreinin self-requested a review April 4, 2023 22:49
@luis-camero luis-camero merged commit 13c46a1 into main Apr 5, 2023
@luis-camero luis-camero deleted the wip-iterables branch April 5, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roni-kreinin roni-kreinin roni-kreinin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luis-camero @roni-kreinin