Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Parsing and Config Containers #1

Merged
merged 9 commits into from
Mar 1, 2023
Merged

Conversation

luis-camero
Copy link
Collaborator

Parsing (i.e. reading a file into a dictionary and reading that dictionary into configuration objects) is handled separately from the containers (i.e. objects that hold the configuration using appropriate python types with checks).

Parsing, including the definition of keys, read/write, and load functions are all encased in parser.py.

Common types, (like IP's and Hostnames) are in common.py.

System, Platform, Mounts, and Sensors will each have their own files.

UnitTests written in PyTest are written in a mirrored package with _test suffixes on all directories, files, classes, and functions.

@luis-camero luis-camero requested review from tonybaltovski and roni-kreinin and removed request for tonybaltovski February 21, 2023 18:25
clearpath_config/parser.py Outdated Show resolved Hide resolved
clearpath_config/system.py Show resolved Hide resolved
clearpath_config/system.py Show resolved Hide resolved
clearpath_config/system.py Outdated Show resolved Hide resolved
clearpath_config_tests/test_system.py Show resolved Hide resolved
clearpath_config/parser.py Show resolved Hide resolved
@luis-camero luis-camero merged commit 3aab506 into main Mar 1, 2023
@luis-camero luis-camero deleted the wip-object-structure branch March 1, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants