Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node version fix Netlify deploy #1065

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Update node version fix Netlify deploy #1065

merged 4 commits into from
Oct 22, 2024

Conversation

ljones140
Copy link
Contributor

@ljones140 ljones140 commented Oct 22, 2024

Update Node in .nvmrc to fix netlify checks and preview deploy

Dockerfiles were previously updated but not the .nvmrc that Neflify uses for node version

As current version does not have language features such as safe navigation, which is causing master -> Netlify preview deploy to fail https://app.netlify.com/sites/blissful-goodall-fa23f6/deploys/6712c7ba40cdac0008071b7c

Tested here and it fixes the master -> prod branch #1066

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for blissful-goodall-fa23f6 ready!

Name Link
🔨 Latest commit 1d8c29a
🔍 Latest deploy log https://app.netlify.com/sites/blissful-goodall-fa23f6/deploys/67179c32d63291000809a8be
😎 Deploy Preview https://deploy-preview-1065--blissful-goodall-fa23f6.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ljones140 ljones140 changed the title Update node version Update node version fix Netlify deploy Oct 22, 2024
@ljones140 ljones140 merged commit 654d7fc into master Oct 22, 2024
7 checks passed
@ljones140 ljones140 deleted the update-node branch October 22, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants