You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 6, 2020. It is now read-only.
Some of our tests employ "skips" to avoid running tests that are known to fail (generally due to open bugs or known limitations). These skips look like this:
skip "This is not working (https://github.com/clearcontainers/tests/issues/694)"
Since we are careful to include an issue number, we could write a tool (check-disabled-tests.{sh,go} ?) that would:
Search for all the skips.
Warn about any skips that do not contain a URL.
Check if the referenced issue is closed.
If the issue is closed, warn that the file needs an update to remove the skip.
This tool should be run regularly (ideally as part of every PR CI run, but weekly would probably suffice) to avoid test code that isn't currently being run from going stale, but also to maximise our test coverage.
The text was updated successfully, but these errors were encountered:
Update the static check script to ignore `file://` URLs which won't
exist (since they only appear in examples).
Fixesclearcontainers#837.
Signed-off-by: James O. D. Hunt <[email protected]>
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Some of our tests employ "skips" to avoid running tests that are known to fail (generally due to open bugs or known limitations). These skips look like this:
ginkgo
:bats
:Since we are careful to include an issue number, we could write a tool (
check-disabled-tests.{sh,go}
?) that would:This tool should be run regularly (ideally as part of every PR CI run, but weekly would probably suffice) to avoid test code that isn't currently being run from going stale, but also to maximise our test coverage.
The text was updated successfully, but these errors were encountered: