Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not handling error messages properly #3

Closed
clcollins opened this issue Dec 11, 2023 · 0 comments · Fixed by #8
Closed

Not handling error messages properly #3

clcollins opened this issue Dec 11, 2023 · 0 comments · Fixed by #8

Comments

@clcollins
Copy link
Owner

clcollins commented Dec 11, 2023

SREPD has an errorMsg tea.Msg type for errors, and it's used in a number of places to return the errors, but for some reason the Update method does not handle these messages properly.

Examples include errors returned from the openOCMContainer() function:

debug 2023/12/11 09:44:51 [fork/exec /usr/bin/gnome-terminal: no such file or directory]

...as well as the acknowledge workflow, when ack'ing an already-resolved incident:

debug 2023/12/11 11:35:10 [setStatus HTTP response failed with status code 400, message: Invalid Input Provided (code: 2001): Incident Already Resolved]
debug 2023/12/11 11:35:10 HTTP response failed with status code 400, message: Invalid Input Provided (code: 2001): Incident Already Resolved

These messages are logged in the debug log, but not handled in the TUI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant