Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about async rendering of Collections in README #43

Open
florianpilz opened this issue Jun 30, 2015 · 1 comment
Open

Warn about async rendering of Collections in README #43

florianpilz opened this issue Jun 30, 2015 · 1 comment

Comments

@florianpilz
Copy link

We spent nearly an hour to find out that automatic re-rendering of Collections does indeed work. We took so long, since the same Jasmine code to assert the changed DOM did not work on collections. (We mocked the AJAX call with a sync callback, so we assumed nothing is async).

However, after looking in the code, rendering of a single model is done in sync and rendering of a collection is done async (using debounce of UnderscoreJS).

I think it would be good to at least warn in the README about this behaviour to spare others the wasted time. Better yet, both update mechanisms should work the same way.

@markijbema
Copy link
Collaborator

I agree, I think we shouldn'the make promises on updating synchronously (react doesn'the really do this either). A warning would help. I'm not sure on making model asynchronous as well. It would make this problem more clear, but it would make debugging harder (I think). But a PR for an improved readme is very welcome of course

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants