Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

component.onModelChange ? #40

Open
tsjoberg opened this issue May 12, 2015 · 4 comments
Open

component.onModelChange ? #40

tsjoberg opened this issue May 12, 2015 · 4 comments

Comments

@tsjoberg
Copy link
Contributor

Believe @markijbema can shed some light on this but I couldn't find an answer:

https://github.com/clayallsopp/react.backbone/blob/master/react.backbone.js#L37

is component.onModelChange a React component property? or added by react.backbone mixin? I couldn't find any reference to this in React docs or in the mixin code as well

@markijbema
Copy link
Collaborator

Seems like an extension point. Default is force update, but if you override onModelChange, that's called instead. If this isn't in the docs, lets keep this issue open until it is ;)

@tsjoberg
Copy link
Contributor Author

Just a proposal but would it make sense to just remove this altogether? Doesn't seem as useful and is not documented anywhere so people would not know this existed without checking the code?

@markijbema
Copy link
Collaborator

It has been here since the very first commit. If you want to remove it, I think we should at least add a deprecation warning:
c15403e

@clayallsopp do you remember why you added this? Do you use this?

@clayallsopp
Copy link
Owner

I don't use this method anymore, fine with removing it or deprecating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants