-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand "Merge categories and keywords" RFC #1
Expand "Merge categories and keywords" RFC #1
Conversation
- As mentioned above, the chance for having duplicates is increased since not | ||
everyone will use the list of recommended keywords. This can be countered to | ||
some degree with aliases for recommended keywords, but can't be prevented | ||
completely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth mentioning that this is also a drawback of the existing system, since many authors include keywords that are similar to categories instead, and there's duplication there as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's very true. see rust-lang/crates.io#7306 as an example
any phrasing suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this?
- As mentioned above, the chance for having duplicates is increased since not | |
everyone will use the list of recommended keywords. This can be countered to | |
some degree with aliases for recommended keywords, but can't be prevented | |
completely. | |
- As mentioned above, the chance for having duplicates is increased since not | |
everyone will use the list of recommended keywords. This can be countered to | |
some degree with aliases for recommended keywords, but can't be prevented | |
completely. That said, we already have duplicates between categories and | |
keywords today, so, moving to just keywords is a strict improvement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"strict improvement" sounds a bit absolute to me. can we soften this up a bit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clarfonthey any thoughts on this? looks like it's the last blocker for merging this :)
Thank you for your work on this! Not sure how many other folks on the crates.io team helped out with the revision, but once the final version of this is done I would like to collect a list of thanks/authors since I think that's worth mentioning. |
Co-authored-by: Clar Fon <[email protected]>
I think I've responded to everything now, so, once you've integrated the suggestions I'd be ready to do a final pass on this. Also just to re-ask my previous question: is there anyone else who helped you out with this you'd like to shout out in the RFC when this is merged, or is this mostly just your work? |
Co-authored-by: Clar Fon <[email protected]>
The text I've written myself, though credits go to all the people in the original discussions. I've just tried to summarize all of the points in a single document :) |
Co-authored-by: Clar Fon <[email protected]>
I'm going to merge this now, and we can modify it more in the RFC discussion. Thank you so much for the help! |
As discussed via Mastodon, this expands your RFC with more details on all of the available solutions and then slightly simplifies it to leave the deprecation on the cargo side up to discussion as an open question for now.
I went through all of the discussions on the original threads from 2016 and also the points that were being brought up in the RFC thread so far and I hope I now captured them all in the RFC text.