-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subtitles/ClosedCaptions never loaded for VOD #4
Comments
I encountered this as well. So far I believed this to be a regression with the 0.4.0 architecture change, as my test stream works (apart from neither Your stream does work in the hls.js demo though. |
As the demo is now updated: pre v0.4.x works - at least with some streams. v0.4.x: does not show subs or rather does not show the selector. Should this be filed for core? |
I faced with same problem. This looks like fixed. if (this._ccTracksUpdated && this.hasClosedCaptionsTracks) But also if hardcode has externalTrack in the same with manifest url, it is causing to bug. |
With the given VOD
https://senvuvod.azureedge.net/pvvodsoc-fl/_definst_/mp4:azrsoc/archives/PV750/2020/2020-06-25/9637_Senate%20sitting%20no.%2027_13-30-41_VL.mp4/playlist.m3u8?audioindex=2
HLSJS.Events.SUBTITLE_TRACK_LOADED is never triggered
HLSJS.Events.SUBTITLE_TRACKS_UPDATED gets triggered
Therefore the closed captions are never loaded. I tried removing
this._playbackType === Playback.LIVE
from the following codebut the hasClosedCaptionsTrack was still false when it ran. To fix my issue, I added the following to the _onTimeUpdate method
Is there a better way to do this?
The text was updated successfully, but these errors were encountered: