Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 665 #796

Merged
merged 2 commits into from
Dec 30, 2016
Merged

Issue 665 #796

merged 2 commits into from
Dec 30, 2016

Conversation

kbknapp
Copy link
Member

@kbknapp kbknapp commented Dec 30, 2016

No description provided.

@kbknapp
fix(Options): fixes a critical bug where options weren't forced to ha…
5a5f2b1 
…ve a value

For instance imagine --opt <val> and --opt2 <val>

Running:

```
$ prog --opt --opt2 val
```

Would pass. This has been fixed.

Closes #665
@kbknapp
test(Options): adds a test against issue 665
327c514
@kbknapp kbknapp mentioned this pull request Dec 30, 2016
Closed
@coveralls
Copy link

coveralls commented Dec 30, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 91.569% when pulling 327c514 on issue-665 into 03f7233 on master.

@kbknapp
Copy link
Member Author

kbknapp commented Dec 30, 2016

@homu r+

@homu
Copy link
Contributor

homu commented Dec 30, 2016

📌 Commit 327c514 has been approved by kbknapp

homu added a commit that referenced this pull request Dec 30, 2016
@homu
Auto merge of #796 - kbknapp:issue-665, r=kbknapp
d872509 
Issue 665
homu added a commit that referenced this pull request Dec 30, 2016
@homu
Auto merge of #796 - kbknapp:issue-665, r=kbknapp
7eb949b 
Issue 665
@homu
Copy link
Contributor

homu commented Dec 30, 2016

⌛ Testing commit 327c514 with merge 7eb949b...

@homu
Copy link
Contributor

homu commented Dec 30, 2016

☀️ Test successful - status

@homu homu merged commit 327c514 into master Dec 30, 2016
@kbknapp kbknapp deleted the issue-665 branch December 31, 2016 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kbknapp @coveralls @homu