Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Settings): Add unset_setting and unset_settings fns to App #598

Merged
merged 1 commit into from
Jul 24, 2016
Merged

feat(Settings): Add unset_setting and unset_settings fns to App #598

merged 1 commit into from
Jul 24, 2016

Conversation

brennie
Copy link

@brennie brennie commented Jul 24, 2016

Closes #590.

@yo-bot
Copy link

yo-bot commented Jul 24, 2016

Thanks for the pull request, and welcome! The team is excited to review your changes, and you should hear from @Vinatorul (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@kbknapp
Copy link
Member

kbknapp commented Jul 24, 2016

Excellent! Thanks for knocking this out! @homu r+

@homu
Copy link
Contributor

homu commented Jul 24, 2016

📌 Commit 8b06d5a has been approved by kbknapp

@homu
Copy link
Contributor

homu commented Jul 24, 2016

⌛ Testing commit 8b06d5a with merge 16028ea...

homu added a commit that referenced this pull request Jul 24, 2016
feat(Settings): Add unset_setting and unset_settings fns to App

Closes #590.
@homu
Copy link
Contributor

homu commented Jul 24, 2016

☀️ Test successful - status

@homu
Copy link
Contributor

homu commented Jul 24, 2016

👀 Test was successful, but fast-forwarding failed: 422 Required status check "continuous-integration/appveyor/pr" is expected

@kbknapp kbknapp merged commit 0ceba23 into clap-rs:master Jul 24, 2016
@brennie brennie deleted the dev/unset-setting branch July 24, 2016 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants