Issue 418

[kbknapp]

No description provided.

[yo-bot]

r? @sru

(yo-bot has picked a reviewer for you, use r? to override)

[sru]

@kbknapp Having is_present to return true when default value is set feels a bit weird IMO, mainly because the argument is actually not present. Otherwise, looks good.

[kbknapp]

That's a good point that I hadn't thought of....let me see if I find a way
to NOT set that (or occurrences of).

On Wed, Feb 10, 2016, 1:21 AM Sung Rim Huh [email protected] wrote:

@kbknapp https://github.com/kbknapp Having is_present to return true
when default value is set feels a bit weird IMO, mainly because the
argument is actually not present. Otherwise, looks good.

—
Reply to this email directly or view it on GitHub
#423 (comment).

[kbknapp]

So now occurrences_of will show 0 but is_present will still return true because it would take some massive changes to not return true. This is because is_present only checks if an argument exists (which happens when there's a value) it has no way of knowing if the value is a default or not.

I think with the docs being very specific about default values and how that interacts with things like is_present or occurrences_of this will be a good compromise.

[kbknapp]

Didn't mean to close....

[kbknapp]

@homu r+

[homu]

📌 Commit 33fe291 has been approved by kbknapp

[homu]

⌛ Testing commit 33fe291 with merge 6b4d387...

[homu]

💔 Test failed - status

[kbknapp]

@homu r+

[homu]

📌 Commit b37c010 has been approved by kbknapp

[homu]

⌛ Testing commit b37c010 with merge e08fdfb...

[homu]

☀️ Test successful - status