name is documented to default to the crate name, but it defaults to the package name

[Nemo157]

Please complete the following tasks

• I have searched the discussions
• I have searched the open and rejected issues

Rust Version

rustc 1.71.0-nightly (9d871b061 2023-05-21)

Clap Version

4.3.0

Minimal reproducible code

[package]
name = "foo"
version = "0.1.0"
edition = "2021"

[dependencies]
clap = { version = "4.3.0", features = ["derive"] }

[[bin]]
name = "bar"
path = "src/main.rs"

use clap::Parser;

#[derive(Parser)]
#[command(version)]
struct Args {}

fn main() {
  Args::parse();
}

Steps to reproduce the bug with the above code

cargo run -- --version

Actual Behaviour

see context

Expected Behaviour

see context

Additional Context

clap/src/_derive/mod.rs

Lines 143 to 144 in 944556e

	//! - `name = <expr>`: [`Command::name`][crate::Command::name]
	//! - When not present: [crate `name`](https://doc.rust-lang.org/cargo/reference/manifest.html#the-name-field) (if on [`Parser`][crate::Parser] container), variant name (if on [`Subcommand`][crate::Subcommand] variant)

states that when not present the "crate name" will be used, but links to the "package name" field.

clap/clap_derive/src/derives/parser.rs

Line 31 in 944556e

let pkg_name = std::env::var("CARGO_PKG_NAME").ok().unwrap_or_default();

uses CARGO_PKG_NAME instead of CARGO_CRATE_NAME.

There's some confusion in the ecosystem about what a "crate" is, I think it's important to be careful to not perpetuate this misunderstanding in documentation.

Debug Output

No response

[epage]

There's some confusion in the ecosystem about what a "crate" is, I think it's important to be careful to not perpetuate this misunderstanding in documentation.

Agreed. I don't think I knew the difference until being on the cargo team for a while