SubcommandsNegateReqs completely disables Arg.required

[wenLiangcan]

App::new("my_app")
                .setting(AppSettings::SubcommandsNegateReqs)
                .arg(Arg::with_name("test")
                       .required(true)
                       .index(1))
                .subcommand(SubCommand::with_name("sub1"))
                .subcommand(SubCommand::with_name("sub1"))

While running:

$ my_app

.required(true) has no effect.

[Vinatorul]

Hello, as you can read in documentation about AppSettings::SubcommandsNegateReqs.

Allows subcommands to override all requirements of the parent (this command). For example if you had a subcommand or even top level application which had a required arguments that are only required as long as there is no subcommand present.

NOTE: This defaults to false (using subcommand does not negate requirements)

So it is expected behavior.
If you don't want for subcommands to override requires - just delete .setting(AppSettings::SubcommandsNegateReqs) call.

Please let me know if you still have problems or not.

[wenLiangcan]

But in my opinion, I think <test> should be required when running my_app without sub1 and sub2.

I have no idea why we need SubcommandsNegateReqs if it should behave as you described, because we can simply omit the declaration of the parent's requirements or declare the parent without the subcommands.

[Vinatorul]

Oh, I'm sorry, you are right, it's a bug.

[kbknapp]

@wenLiangcan Thanks for finding and taking the time to file this issue! As @Vinatorul said, it's in fact a bug. We'll get this patched and put out v1.2.3 shortly 👍

[Vinatorul]

@kbknapp I can do it, when come home in about one hour.

[kbknapp]

Sounds good thanks!

[wenLiangcan]

Thanks for the quick responses, @Vinatorul , @kbknapp 😄

[kbknapp]

@wenLiangcan the new version (v1.2.3) has been published to crates.io thanks to @Vinatorul

Let us know if you have any other questions or issues! 😄

[wenLiangcan]

@kbknapp Thank you, I tried the new version and it works well now!

Thanks for your great job, @Vinatorul 👏

[Vinatorul]

At your service ;)