fix cargo clippy complaint (collapsible_if)

clap-rs · May 21, 2020 · 8489bf3 · 8489bf3
1 parent 95c7521
commit 8489bf3
Showing 1 changed file with 14 additions and 15 deletions.
diff --git a/src/parse/parser.rs b/src/parse/parser.rs
@@ -1278,23 +1278,22 @@ where
                 &*Usage::new(self).create_usage_with_title(&[]),
                 self.app.color(),
             )?);
+        } else if needs_eq && min_vals_zero {
+            debug!("None and requires equals, but min_vals == 0");
+            if !opt.default_missing_vals.is_empty() {
+                debug!("Parser::parse_opt: has default_missing_vals");
+                for val in &opt.default_missing_vals {
+                    debug!("Parser::parse_opt: adding value from default_missing_values; val = {:?}", val);
+                    self.add_val_to_arg(
+                        opt,
+                        &ArgStr::new(val),
+                        matcher,
+                        ValueType::CommandLine,
+                    )?;
+                }
+            };
         } else {
             debug!("None");
-            if needs_eq && min_vals_zero {
-                // OPTION with missing optional value?
-                if !opt.default_missing_vals.is_empty() {
-                    debug!("Parser::parse_opt: has default_missing_vals");
-                    for val in &opt.default_missing_vals {
-                        debug!("Parser::parse_opt: adding value from default_missing_values; val = {:?}", val);
-                        self.add_val_to_arg(
-                            opt,
-                            &ArgStr::new(val),
-                            matcher,
-                            ValueType::CommandLine,
-                        )?;
-                    }
-                };
-            }
         }
 
         matcher.inc_occurrence_of(&opt.id);