-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish pre-release extensions in the store #765
Comments
I'm trying to think through the logistics of how this should work. Currently, we have two CI workflows for creating releases:
If we're going to publish unstable releases to the VSCode Marketplace, I guess we'll want to identify them with a version number rather than a SHA? And maybe it doesn't need to be a dedicated version number, maybe we can "promote" an unstable release package itself to stable? One potential way it could work is:
I'm open to suggestions / alternatives. |
I see 2 flows here:
I'd be inclined to use the second flow as it reduces complexity while releasing an older pre-release seems rather exceptional. (A revert can be used in that case) As such, I think that:
With this, the release flow can be automated and create 2 sequential PRs. (Or 1, if the releasing occurs with data different from checkout) As suggested by the documentation, we should use even numbers for releases and odd numbers for pre-release. Alternatively, we can use the patch number 0 as a release. An example, each line is a PR:
I feel more for the first flow of version numbering. |
I'm a bit concerned about it working this way, as it means every PR merge automatically pushes out a new version to the VSCode Marketplace; even if it's just a pre-release version, users who have opted into the pre-release channel can be upgraded to that automatically. I think it would be safer if pushing a new version to the VSCode Marketplace required an explicit action opting into that, i.e. either a manual Github Action invocation, or a special commit that touches a version number. |
I'm a bit afraid that with manual work, the pre-release will only happen when we actually want a release. Though at the same time, I think it would be a small change if we change our minds. So let's start with the manual triggers and we can always see how that goes. |
In either case, implementing these workflows will take some hacking on the Github Actions scripts. I'm not sure when I'll get around to that. @JVApen, if you have the time and interest in trying to make these Github Actions changes, that would of course be appreciated. However, if you're keen for the |
I don't have any experience with GitHub Actions, though with the manual trigger it feels like a small adjustment of the existing script. |
Recently the creation of pre-release versions of the extension was added. This publishes to GitHub.
Visual Studio Code has the concept of pre-release built-in, so it would be useful to make use of that. As such, we would get a larger reach and reduce the burden for people to test this.
Documentation about this can be found here
The text was updated successfully, but these errors were encountered: