code clean up and removes console.log

contributor-assistant · May 16, 2021 · c2727f2 · c2727f2
1 parent 655a7dc
commit c2727f2
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 20 deletions.
diff --git a/lib/main.js b/lib/main.js
diff --git a/src/main.ts b/src/main.ts
@@ -11,7 +11,9 @@ export async function run() {
   try {
     core.info(`CLA Assistant GitHub Action bot has started the process`)
 
-    // using a `string` true or false purposely as github action input cannot have a boolean value
+    /*
+    * using a `string` true or false purposely as github action input cannot have a boolean value
+    */
     if (context.payload.action === 'closed' && input.lockPullRequestAfterMerge() == 'true') {
       return lockPullRequest()
     } else {

diff --git a/src/pullrequest/pullRequestComment.ts b/src/pullrequest/pullRequestComment.ts
@@ -4,7 +4,6 @@ import signatureWithPRComment from './signatureComment'
 import { commentContent } from './pullRequestCommentContent'
 import {
   CommitterMap,
-  ReactedCommitterMap,
   CommittersDetails
 } from '../interfaces'
 import { getUseDcoFlag } from '../shared/getInputs'
@@ -13,12 +12,6 @@ import { getUseDcoFlag } from '../shared/getInputs'
 
 export default async function prCommentSetup(committerMap: CommitterMap, committers: CommittersDetails[]) {
   const signed = committerMap?.notSigned && committerMap?.notSigned.length === 0
-  console.log(signed)
-  // let signed = false
-
-  // if (committerMap?.notSigned && committerMap?.notSigned.length === 0) {
-  //   signed = true
-  // }
 
   try {
     const claBotComment = await getComment()

diff --git a/src/setupClaCheck.ts b/src/setupClaCheck.ts
@@ -17,22 +17,17 @@ export async function setupClaCheck() {
     core.setFailed('Please enter a personal access token as a environment variable in the CLA workflow file as described in the https://github.com/cla-assistant/github-action documentation')
     return
   }
-  // let signed: boolean = false
+
   let committers = await getCommitters()
   committers = checkAllowList(committers)
 
   const { claFileContent, sha } = await getCLAFileContentandSHA(committers, committerMap) as ClafileContentAndSha
 
   committerMap = prepareCommiterMap(committers, claFileContent) as CommitterMap
-  console.log('committerMap :>> ', committerMap)
 
   try {
     const reactedCommitters = await prCommentSetup(committerMap, committers) as ReactedCommitterMap 
 
-    // if (signed) {
-    //   core.info(`All committers have signed the CLA`)
-    //   return reRunLastWorkFlowIfRequired()
-    // }
     if (reactedCommitters?.newSigned.length) {
       /* pushing the recently signed  contributors to the CLA Json File */
       await updateFile(sha, claFileContent, reactedCommitters)
@@ -44,11 +39,6 @@ export async function setupClaCheck() {
       core.setFailed(`committers of Pull Request number ${context.issue.number} have to sign the CLA 📝`)
     }
 
-    // if (committerMap?.notSigned === undefined || committerMap.notSigned.length === 0) {
-    //   core.info(`All contributors have signed the CLA2`)
-    //   return reRunLastWorkFlowIfRequired()
-    // } 
-
   } catch (err) {
     core.setFailed(`Could not update the JSON file: ${err.message}`)
   }