Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nkf to gemspec #66

Closed
kapitoshka438 opened this issue Feb 15, 2024 · 4 comments
Closed

Add nkf to gemspec #66

kapitoshka438 opened this issue Feb 15, 2024 · 4 comments

Comments

@kapitoshka438
Copy link

kapitoshka438 commented Feb 15, 2024

After upgrading to Ruby 3.3.0 running bundle install for a single Gemfile which only contains Fastlane gem shows this warning

{PROJECT_ROOT}/vendor/bundle/ruby/3.3.0/gems/CFPropertyList-3.0.6/lib/cfpropertylist/rbCFPropertyList.rb:3: warning: kconv is found in nkf, which will no longer be part of the default gems since Ruby 3.4.0. Add nkf to your Gemfile or gemspec. Also contact author of CFPropertyList-3.0.6 to add nkf into its gemspec.
@ckruse ckruse closed this as completed in 4c68eaf Feb 15, 2024
@ckruse ckruse reopened this Feb 15, 2024
@ckruse
Copy link
Owner

ckruse commented Feb 15, 2024

Should be fixed now, at least I no longer can reproduce it on my dev machine. Can you confirm?

@kapitoshka438
Copy link
Author

After taking a look on your changes I can assume that it will work for Ruby 3.4.0 (which is not released yet) but it won't fix the Ruby 3.3.0 warning. But it's probably fine.

@ckruse
Copy link
Owner

ckruse commented Feb 15, 2024

Sorry, I remembered it wrong. You are right, should be specified for 3.3, too.

@ckruse ckruse closed this as completed in a0959e1 Feb 15, 2024
@ckruse
Copy link
Owner

ckruse commented Feb 15, 2024

Ok, I pushed a new version to rubygems. Thank you for your report! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants