Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips do not show up until the page is refreshed #375

Closed
dufipl opened this issue Oct 5, 2022 · 9 comments
Closed

Tooltips do not show up until the page is refreshed #375

dufipl opened this issue Oct 5, 2022 · 9 comments
Assignees
Labels
bug Something isn't working regression squad:features upstream Dependent/related to external issues
Milestone

Comments

@dufipl
Copy link

dufipl commented Oct 5, 2022

📝 Provide detailed reproduction steps (if any)

  1. Build GH Writer on ghw/epic/388-version-3521-bump branch
  2. Try to open a new issue.
  3. Hover toolbar buttons, if tooltips show up, go to the issue list and try to create the issue again.

✔️ Expected result

Tooltips show up regardless of the cache.

❌ Actual result

Tooltips do not show up until the page is refreshed
tooltips issue


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@dufipl dufipl added the bug Something isn't working label Oct 5, 2022
@mlewand
Copy link
Contributor

mlewand commented Oct 5, 2022

Interesting, this issue should be in case reproducible in vanilla CKE5 - let's investigate it further.

@Acrophost
Copy link

More bugs most likely related to cache (occur when tooltips are not showing up):

In markdown (nostalgia) editing there is no preview or bottom bar for adding files from computer. Hard refresh/clearing cache fixes it just like tooltips 

@mateuszzagorski

This comment was marked as off-topic.

@mateuszzagorski
Copy link
Contributor

mateuszzagorski commented Oct 6, 2022

Regarding the tooltips what I see is that inside the ck-body-wrapper we're missing a div with ck ck-balloon-panel ck-balloon-panel_arrow_n ck-balloon-panel_with-arrow ck-tooltip classes.  

In the recently added tooltipManager we have the bodyViewCollection that's set to first( TooltipManager._editors.values() ) and because of that we're targeting the editor that's no longer visible but it is still available via the TooltipManager._editors.values().  

So in my opinion we have to update the ckeditor5-ui plugin in order to fix the issue.

You can replicate the similar behavior in ckeditor5:
- use the all-types manual test
- destroy the ClassicEditor
Without it tooltips will no longer be visible in all the other editors.

Additional notes:
- Clearing up the TooltipManager._editors set seems to fix the issue for GitHub Writer - but it does not work well for ckeditor5 itself so it needs to be investigated further at the source.

@Dumluregn
Copy link
Contributor

I agree with @mateuszzagorski 's conclusions. I'll report an upstream issue in CKE5 repo and once it's resolved, we should go back here to ensure it fixed Writer.

@Dumluregn
Copy link
Contributor

Reported in ckeditor/ckeditor5#12602.

@Dumluregn Dumluregn added upstream Dependent/related to external issues regression labels Oct 7, 2022
@mlewand
Copy link
Contributor

mlewand commented Oct 10, 2022

Closing as an upstream issue.

@mlewand mlewand closed this as completed Oct 10, 2022
@dufipl
Copy link
Author

dufipl commented Oct 24, 2022

@mlewand As the upstream issue is closed, I assume it should be fixed, but it's not, therefore I will reopen the issue.

Updating branch in reproduction steps to ghw/epic/388-version-3521-bump.

@dufipl dufipl reopened this Oct 24, 2022
@dufipl dufipl changed the title Tooltips do not show up until the cache is cleared Tooltips do not show up until the page is refreshed Oct 24, 2022
@Dumluregn Dumluregn self-assigned this Nov 14, 2022
@mlewand
Copy link
Contributor

mlewand commented Nov 16, 2022

This should be fixed with #417.

@mlewand mlewand closed this as completed Nov 16, 2022
@mlewand mlewand added this to the 1.10.1 milestone Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression squad:features upstream Dependent/related to external issues
Projects
None yet
Development

No branches or pull requests

5 participants