From c5172dd269483611250af8ab056cf986ec734b8e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Remiszewski?= Date: Mon, 4 Mar 2024 15:07:00 +0100 Subject: [PATCH 1/2] Add menu bar integration. --- packages/ckeditor5-ui/src/menubar/utils.ts | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/packages/ckeditor5-ui/src/menubar/utils.ts b/packages/ckeditor5-ui/src/menubar/utils.ts index b0f508a2562..fa29175be00 100644 --- a/packages/ckeditor5-ui/src/menubar/utils.ts +++ b/packages/ckeditor5-ui/src/menubar/utils.ts @@ -395,6 +395,13 @@ export const MenuBarMenuViewPanelPositioningFunctions: Record Date: Thu, 7 Mar 2024 14:27:41 +0100 Subject: [PATCH 2/2] Improved spinner rendering in menu bar buttons. --- .../components/menubar/menubarmenulistitembutton.css | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/packages/ckeditor5-theme-lark/theme/ckeditor5-ui/components/menubar/menubarmenulistitembutton.css b/packages/ckeditor5-theme-lark/theme/ckeditor5-ui/components/menubar/menubarmenulistitembutton.css index ee373d37486..546698b9389 100644 --- a/packages/ckeditor5-theme-lark/theme/ckeditor5-ui/components/menubar/menubarmenulistitembutton.css +++ b/packages/ckeditor5-theme-lark/theme/ckeditor5-ui/components/menubar/menubarmenulistitembutton.css @@ -14,6 +14,18 @@ min-width: var(--ck-menu-bar-menu-item-min-width); } + & > .ck-spinner-container, + & > .ck-spinner-container .ck-spinner { + /* These styles correspond to .ck-icon so that the spinner seamlessly replaces the icon. */ + --ck-toolbar-spinner-size: 20px; + } + + & > .ck-spinner-container { + /* These margins are the same as for .ck-icon. */ + margin-left: calc(-1 * var(--ck-spacing-small)); + margin-right: var(--ck-spacing-small); + } + /* * Hovered items automatically get focused. Default focus styles look odd * while moving across a huge list of items so let's get rid of them