Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and stabilize external spell checkers after migration to beforeinput #8064

Closed
oleq opened this issue Sep 11, 2020 · 2 comments
Closed
Labels
domain:dx This issue reports a developer experience problem or possible improvement. domain:ui/ux This issue reports a problem related to UI or UX. package:typing resolution:duplicate This issue is a duplicate of another issue and was merged into it. squad:core Issue to be handled by the Core team.

Comments

@oleq
Copy link
Member

oleq commented Sep 11, 2020

Let's make sure WSC and Grammarly work OK (but first: how do they work?) when we switch to beforeinput-based typing. There could be some clashes, especially in collaboration features.

@oleq oleq added domain:dx This issue reports a developer experience problem or possible improvement. domain:ui/ux This issue reports a problem related to UI or UX. package:typing squad:dx labels Sep 11, 2020
@oleq oleq added this to the iteration 36 milestone Sep 11, 2020
@oleq
Copy link
Member Author

oleq commented Sep 15, 2020

  • Grammarly used the native DOM API to change the selection and then fires a clipboard event to accept the suggestion. It works fine and seems beyond the scope of beforeinput migration.
  • The spell checking in Safari on Mac and Chrome spell checking (independent from Mac's) are handled correctly via insertText and insertReplacementText beforeinput events.
  • It looks like the EnterObserver integration with beforeinput might be necessary out-of-the box because sometimes accepting system suggestions using enter creates unnecessary paragraph (Migrate the Enter and ShiftEnter plugins to beforeInput #7999).

@Reinmar Reinmar modified the milestones: iteration 36, iteration 37 Sep 28, 2020
@Reinmar Reinmar modified the milestones: iteration 37, nice-to-have Oct 14, 2020
@Reinmar Reinmar added the squad:core Issue to be handled by the Core team. label Sep 9, 2021
@Reinmar Reinmar removed the squad:dx label Sep 27, 2021
@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
@Reinmar
Copy link
Member

Reinmar commented Jul 19, 2022

Closed together with #7462. We're reorganizing the work in #11438.

@Reinmar Reinmar closed this as completed Jul 19, 2022
@Reinmar Reinmar added the resolution:duplicate This issue is a duplicate of another issue and was merged into it. label Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:dx This issue reports a developer experience problem or possible improvement. domain:ui/ux This issue reports a problem related to UI or UX. package:typing resolution:duplicate This issue is a duplicate of another issue and was merged into it. squad:core Issue to be handled by the Core team.
Projects
None yet
Development

No branches or pull requests

3 participants