Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception thrown when undoing link with a non-collapsed selection #8052

Closed
mlewand opened this issue Sep 9, 2020 · 2 comments
Closed

Exception thrown when undoing link with a non-collapsed selection #8052

mlewand opened this issue Sep 9, 2020 · 2 comments
Labels
browser:chrome domain:ui/ux This issue reports a problem related to UI or UX. package:link resolution:expired This issue was closed due to lack of feedback. status:stale type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.

Comments

@mlewand
Copy link
Contributor

mlewand commented Sep 9, 2020

📝 Provide detailed reproduction steps (if any)

👀 The issue should get fixed by #7462 👀

  1. Open https://ckeditor.com/docs/ckeditor5/22.0.0/examples/builds/classic-editor.html
  2. Focus the editor.
  3. Remove all the content.
  4. Type few words.
  5. Select the last word.
  6. Use link command with ctrl/cmd + k
  7. Press ctrl/cmd + z to trigger undo

✔️ Expected result

At least exception is not thrown (I don't think that pressing ctrl+z with link plugin should invoke undo in a first place).

❌ Actual result

An exception is thrown:

snippet.js:4 Uncaught TypeError: Cannot read property 'is' of undefined
    at rt.findPositionIn (snippet.js:4)
    at rt.on.priority (snippet.js:4)
    at rt.fire (snippet.js:4)
    at rt.toViewPosition (snippet.js:4)
    at rt.toViewRange (snippet.js:4)
    at T._getBalloonPositionData (snippet.js:4)
    at f.s (snippet.js:4)
    at fire (snippet.js:4)
    at f.update (snippet.js:4)
    at a.<anonymous> (snippet.js:4)

📃 Other details

Interestingly it is not reproducible on FF. It's similar to #7903.

  • Browser: Chrome (didn't check Safari)
  • OS: Win10 (didn't check other)
  • CKEditor version: v22.0.0

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@mlewand mlewand added type:bug This issue reports a buggy (incorrect) behavior. package:link domain:ui/ux This issue reports a problem related to UI or UX. type:regression This issue reports a bug that was not present in the previous releases. labels Sep 9, 2020
@mlewand mlewand mentioned this issue Sep 10, 2020
13 tasks
@Mgsy Mgsy added this to the next milestone Sep 14, 2020
@pomek pomek modified the milestones: next, nice-to-have Nov 10, 2020
@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 12, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser:chrome domain:ui/ux This issue reports a problem related to UI or UX. package:link resolution:expired This issue was closed due to lack of feedback. status:stale type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.
Projects
None yet
Development

No branches or pull requests

4 participants