Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement basic composition (IME) support using beforeInput #8007

Closed
oleq opened this issue Sep 3, 2020 · 3 comments
Closed

Implement basic composition (IME) support using beforeInput #8007

oleq opened this issue Sep 3, 2020 · 3 comments
Assignees
@oleq @niegowski
Labels
domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). domain:ui/ux This issue reports a problem related to UI or UX. package:typing resolution:duplicate This issue is a duplicate of another issue and was merged into it. squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@oleq
Copy link
Member

oleq commented Sep 3, 2020 •
edited by mlewand
Loading

Provide a description of the task

This includes insertCompositionText, deleteByComposition beforeInput types and compositionstart/end handling on the document-level.

So far, the only working strategy was blocking Renderer and SelectionObserver completely when the composition is on and then a single transaction to the model on compositionend. There are some concerns regarding this strategy, though (e.g. autocomplete).
@oleq oleq added type:task This issue reports a chore (non-production change) and other types of "todos". domain:dx This issue reports a developer experience problem or possible improvement. domain:ui/ux This issue reports a problem related to UI or UX. package:typing domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). and removed domain:dx This issue reports a developer experience problem or possible improvement. labels Sep 3, 2020
@oleq oleq added this to the iteration 36 milestone Sep 3, 2020
@oleq oleq added the squad:dx label Sep 3, 2020
@Reinmar Reinmar modified the milestones: iteration 36, iteration 37 Sep 28, 2020
@oleq
Copy link
Member Author

oleq commented Sep 29, 2020

This issue is essential for basic typing on Android. Check out my comment to learn more.

@oleq oleq assigned oleq and unassigned oleq Oct 5, 2020
@oleq
Copy link
Member Author

oleq commented Oct 6, 2020

  • WIP in branch i/8007-beforeinput-composition.
  • Problem: Typing over a widget. We need to move the DOM selection from the fake container to the content and remove the widget there. The browser will not do that by itself, so we need to. So that needs to be the renderer.
  • Problem: Typing over multiple table cells.

@Reinmar Reinmar modified the milestones: iteration 37, nice-to-have Oct 14, 2020
@oleq oleq mentioned this issue Jan 18, 2021
Open
@Reinmar Reinmar added the squad:core Issue to be handled by the Core team. label Sep 9, 2021
@Reinmar Reinmar removed the squad:dx label Sep 27, 2021
@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
@Reinmar
Copy link
Member

Reinmar commented Jul 19, 2022

Closed together with #7462. We're reorganizing the work in #11438.

@Reinmar Reinmar closed this as completed Jul 19, 2022
@Reinmar Reinmar added the resolution:duplicate This issue is a duplicate of another issue and was merged into it. label Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

@niegowski niegowski

Labels
domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). domain:ui/ux This issue reports a problem related to UI or UX. package:typing resolution:duplicate This issue is a duplicate of another issue and was merged into it. squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Reinmar @oleq @niegowski @pomek